perf(export): stream heartbeat export data #464
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deployor
changed the title
maxwofford
reviewed
Aug 9, 2025
| type: "application/json", | ||
| disposition: "attachment" | ||
| } | ||
| ActiveRecord::Base.clear_active_connections! |
There was a problem hiding this comment.
are you sure you mean to do this?
There was a problem hiding this comment.
Yea? Thats the exact one change i made from before, Its not global no? It clears the connections from the where clause that are idle-
There was a problem hiding this comment.
Correct me if im wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#460 This time, the connection is cleared after every batch, which should resolve the issue that @3kh0 had.
ActiveRecord::Base.clear_active_connections! <---
Streaming should resolve performance issues.